fix: Should also verify non sha1 output

packages/installer/diagnose.ts

@@ -53,11 +53,11 @@ export async function diagnoseInstall(installProfile: InstallProfile, minecraftL
   }))
   for (const proc of processors) {
     if (proc.outputs) {
-      for (const file in proc.outputs) {
+      for (const [file, checksum] of Object.entries(proc.outputs)) {
         const issue = await diagnoseFile({
           role: 'processor',
           file,
-          expectedChecksum: proc.outputs[file].replace(/'/g, ''),
+          expectedChecksum: checksum.replace(/'/g, ''),
           hint: 'Re-install this installer profile!',
         })
         if (issue) {

packages/installer/forge.ts

@@ -119,17 +119,17 @@ type RequiredVersion = {
   installer?: {
     sha1?: string
     /**
-         * The url path to concat with forge maven
-         */
+     * The url path to concat with forge maven
+     */
     path: string
   }
   /**
-     * The minecraft version
-     */
+   * The minecraft version
+   */
   mcversion: string
   /**
-     * The forge version (without minecraft version)
-     */
+   * The forge version (without minecraft version)
+   */
   version: string
 }
 

packages/installer/profile.ts

@@ -115,13 +115,29 @@ export function resolveProcessors(side: 'client' | 'server', installProfile: Ins
       server: dirname(variables.INSTALLER.server),
     }
   }
-  const processors = (installProfile.processors || []).map((proc) => ({
-    ...proc,
-    args: proc.args.map(normalizePath).map(normalizeVariable),
-    outputs: proc.outputs
+
+  const resolveOutputs = (proc: PostProcessor, args: string[]) => {
+    const original = proc.outputs
       ? Object.entries(proc.outputs).map(([k, v]) => ({ [normalizeVariable(k)]: normalizeVariable(v) })).reduce((a, b) => Object.assign(a, b), {})
-      : undefined,
-  })).filter((proc) => proc.sides ? proc.sides.indexOf(side) !== -1 : true)
+      : {}
+    for (const [key, val] of Object.entries(original)) {
+      original[key] = val.replace(/'/g, '')
+    }
+    const outputIndex = args.indexOf('--output')
+    const outputFile = outputIndex !== -1 ? args[outputIndex + 1] : undefined
+    if (outputFile && !original[outputFile]) {
+      original[outputFile] = ''
+    }
+    return original
+  }
+  const processors = (installProfile.processors || []).map((proc) => {
+    const args = proc.args.map(normalizePath).map(normalizeVariable)
+    return {
+      ...proc,
+      args,
+      outputs: resolveOutputs(proc, args),
+    }
+  }).filter((proc) => proc.sides ? proc.sides.indexOf(side) !== -1 : true)
   return processors
 }
 
@@ -248,6 +264,8 @@ export class PostProcessingTask extends AbortableTask<void> {
   protected async isInvalid(outputs: Required<PostProcessor>['outputs']) {
     for (const [file, expect] of Object.entries(outputs)) {
       const sha1 = await checksum(file, 'sha1').catch((e) => '')
+      if (!sha1) return true // if file not exist, the file is not generated
+      if (!expect) return false // if expect is empty, we just need file exists
       const expected = expect.replace(/'/g, '')
       if (expected !== sha1) {
         return true