Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 Rate limit retry #51

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🔄 Rate limit retry #51

wants to merge 1 commit into from

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Oct 16, 2024

Rate Limit

Catches all HTTP 429 Too many requests

  • Waits for the Retry-After header value in seconds
  • Retries the API call
  • Fails after 5 tries

Closes #50

@mrharpo mrharpo self-assigned this Oct 16, 2024
@mrharpo mrharpo added the enhancement ➕ New feature or request label Oct 16, 2024
@mrharpo mrharpo added this to the v0.4.0 Rate limit ♾️ milestone Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.60%. Comparing base (8723d5b) to head (8b0701d).

Files with missing lines Patch % Lines
sonyci/utils.py 41.66% 14 Missing ⚠️
sonyci/sonyci.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   78.07%   74.60%   -3.47%     
==========================================
  Files           8        9       +1     
  Lines         228      256      +28     
==========================================
+ Hits          178      191      +13     
- Misses         50       65      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Retry on rate limit error
2 participants