Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New roles for seeing cruises and lowerings without access to events. Tests for guest role #36

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

figuernd
Copy link
Contributor

@figuernd figuernd commented Aug 29, 2024

Completes SL-44 (Jira).

Adds two new roles: cruise_watcher and lowering_watcher. Note that the three watchers' scopes are proper subsets of another, in this order: event_watcher > lowering_watcher > cruise_watcher.
This is because accessing events does not make sense if you cannot also access their containing cruises and lowerings. More importantly, however, is that event_watcher has historically included cruise and lowerings, and changing those scopes would require a database migration task for all existing deployments.

@figuernd figuernd requested a review from rgov August 29, 2024 19:18
@figuernd figuernd merged commit ea4e3a4 into master Sep 20, 2024
2 checks passed
@figuernd figuernd deleted the nathan.figueroa/SL-44 branch September 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant