Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA & GS SUMO updates #1213

Merged
merged 2 commits into from
Aug 15, 2023
Merged

GA & GS SUMO updates #1213

merged 2 commits into from
Aug 15, 2023

Conversation

rtravis-whoi
Copy link

This PR includes MET sensor additions to GA & GS deploy csvs, as well as Roundabout template revision letters.

RDB_BuildTemplateRevs.xlsx
METBK_Module_Heights_RGT_2023-06-27.xlsx

Copy link
Collaborator

@sauuyer sauuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA01SUMO_Deploy.csv

  • METLGR-00034 in deploy csv but not METBK_Module_Heights_RGT_2023-06-27.xlsx or in the Calibratio_CSV_Efforts google sheet
  • Seems like FDCHP is missing from this cal csv?

GS01SUMO_Deploy.csv

  • GS01SUMO-SBD12-08-FDCHPA000 not in Calibration_CSV_Efforts google sheet
  • GS01SUMO-SBD12-06-METBKA000 not in Calibration_CSV_Efforts google sheet

Copy link
Collaborator

@sauuyer sauuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after slacking with Rebecca

Copy link

@cooleyky cooleyky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

NBP1609,,AT39-03,,GA01SUMO-SBD12-06-METBKA005,3,1,2016-10-27T01:47:00,2018-01-14T10:24:00,CGMGA-01SUMO-00003,,CGINS-METPRC-00273,-42.9204,-42.44093167,,-5,5175,,,B
NBP1609,,AT39-03,,GA01SUMO-SBD12-06-METBKA006,3,1,2016-10-27T01:47:00,2018-01-14T10:24:00,CGMGA-01SUMO-00003,,CGINS-METSWR-00271,-42.9204,-42.44093167,,-5,5175,,,B
NBP1609,,AT39-03,,GA01SUMO-SBD12-06-METBKA007,3,1,2016-10-27T01:47:00,2018-01-14T10:24:00,CGMGA-01SUMO-00003,,CGINS-METWND-00265,-42.9204,-42.44093167,,-6,5175,,,B

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

DY096,,DY112,,GS01SUMO-SBD12-06-METBKA006,4,1,2018-12-04T17:10:40,2020-01-20T10:01:00,CGMGS-01SUMO-00004,,CGINS-METSWR-00249,-54.407168,-89.206037,,-5,4589,,,C
DY096,,DY112,,GS01SUMO-SBD12-06-METBKA007,4,1,2018-12-04T17:10:40,2020-01-20T10:01:00,CGMGS-01SUMO-00004,,CGINS-METWND-00243,-54.407168,-89.206037,,-6,4589,,,C
DY096,,DY112,,GS01SUMO-SBD12-08-FDCHPA000,4,1,2018-12-04T17:10:40,2020-01-20T10:01:00,CGMGS-01SUMO-00004,,CGINS-FDCHPA-74102,-54.407168,-89.206037,,-6,4589,,,C

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cooleyky cooleyky added Ready to merge Reviews completed and removed 2nd Review needed labels Aug 1, 2023
Updating SUMO_updates from main w/oceanobservatories updates
@reedan88 reedan88 merged commit ad493f7 into main Aug 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviews completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants