Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to IETF B&A standard #1288

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Link to IETF B&A standard #1288

merged 6 commits into from
Oct 1, 2024

Conversation

brusshamilton
Copy link
Contributor

@brusshamilton brusshamilton commented Sep 30, 2024 •
edited by pr-preview bot
Loading

@qingxinwu qingxinwu added the spec Relates to the spec label Sep 30, 2024
qingxinwu
qingxinwu reviewed Sep 30, 2024
View reviewed changes
spec.bs Outdated
@@ -3178,10 +3173,8 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|config|)</dfn> meth
1. Let |requestId| be the [=string representation=] of a [=version 4 UUID=].
1. Set |result|'s {{AdAuctionData/requestId}} field to |requestId|.
1. Let |context| be the result of serializing |igMap| using |config| into |result|'s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this step mean "1. let |context| be .... 1. Set |result|'s {...} to |context|"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's more like

1. Let (|requestBlob|, |context|) be the result of serializing |igMap| using |config|.
2. Set |result|'s {{AdAuctionData/request}} to |requestBlob|.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change it to this then. It's much clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

qingxinwu
qingxinwu approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % two suggested changes.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@JensenPaul JensenPaul merged commit bd5b6f2 into WICG:main Oct 1, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 1, 2024
@brusshamilton @github-actions
Link to IETF B&A standard (#1288)
b8b9ed2 
SHA: bd5b6f2
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@qingxinwu qingxinwu mentioned this pull request Oct 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingxinwu qingxinwu qingxinwu approved these changes

Assignees
No one assigned
Labels
spec Relates to the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusshamilton @qingxinwu @JensenPaul