-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Add publisher to ad auction data config #1291
Conversation
|
||
1. Let |seller| be the result of running [=parse an https origin=] on | ||
|configIDL|["{{AdAuctionDataConfig/seller}}"]. | ||
1. Let |coordinator| be the result of running [=parse an https origin=] on | ||
|configIDL|["{{AdAuctionDataConfig/coordinatorOrigin}}"]. | ||
1. If |seller| or |coordinator| are failure, then [=exception/throw=] a {{TypeError}}. | ||
1. Let |config| be a new [=auction data config=] with the following [=struct/items=]: | ||
: [=auction data config/publisher=] | ||
:: |top_level_origin| | ||
: [=auction data config/seller=] | ||
:: |seller| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the IETF's algorithm does not take a seller in its inputs. Is there a problem of passing seller to that algorithm? If not, I think it would be fine, otherwise, need to move this out from [=auction data config=].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine.
Co-authored-by: qingxinwu <[email protected]>
SHA: 840355a Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 840355a Reason: push, by morlovich Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview | Diff