Add webIDL dictionaries for reporting browser signals #678
Conversation
|
@jyasskin Would you mind taking a look? Thanks. I believe this is still needed after changing script runner to use WebIDL callback invocation |
|
@jyasskin friendly ping. |
spec.bs
Outdated
| <dd>Advertiser click or conversion cost passed from `generateBid()` to `reportWin()`. Non-negative | ||
| and only the lowest 8 bits will be passed |
There was a problem hiding this comment.
I'm not sure what the "lowest 8 bits" means for a double. Is this the rounding operation from above?
There was a problem hiding this comment.
Updated.
yes, it's the rounding operation from above.
I copied from the existing "lowest 12 bits", but after double check, that was wrong. It is 8 bits of precision in the mantissa (not including sign) and 8 bits in the exponent(code).
Another thing we need to update about the [=round a value=] algorithm is letting it take a parameter (K) about the number of precision in the mantissa. Different Ks are used for different fields in our implementation.
spec.bs
Outdated
| not null, and |buyer| is [=same origin=] with |leadingBidInfo|'s | ||
| [=leading bid info/highest scoring other bid owner=], false otherwise | ||
| <dt>{{ReportWinBrowserSignals/interestGroupName}} | ||
| <dd>|interestGroupName| if it is not null, {{undefined}} otherwise |
There was a problem hiding this comment.
I think this can't be null anymore.
| <dd>|interestGroupName| if it is not null, {{undefined}} otherwise | |
| <dd>|interestGroupName| |
There was a problem hiding this comment.
This turns out to be much more complicated than just passing the IG name.
There's an open PR handling it (it's the report id stuff), so I'll just leave a todo here
Co-authored-by: Jeffrey Yasskin <[email protected]>
SHA: 77601ee Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 77601ee Reason: push, by morlovich Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 77601ee.
Change reportWin and reportResult's browser signals from ordered maps to dictionaries, so that they can be converted to JS values and passed to javascript methods.
Also fixed an error about ad cost, which will be the last 8 bits instead of 12 bits. See the explainer
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Jul 11, 2023, 11:23 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.