BE | Create PuzzlesController#index Endpoint
#26
Conversation
There was a problem hiding this comment.
Hi Kemi!
This is a great start with the basic logic in place. Here is what we need to do before this PR can be merged:
-
Please pull down main into your branch on your local computer and handle any merge conflicts there.
- This is because I added the necessary items for deploying to Heroku and CI/CD yesterday...which is why this PR did not pass the tests and cannot be merged
-
We should schedule a time to meet so we can review what is necessary for creating an API style app. You're work here has all the basic elements but is not complete.
- To get a head start on this, you could review my work in the PR called
BE | Create Users#show Endpointwhich will give you a better idea of what needs to be done.
- To get a head start on this, you could review my work in the PR called
Hey Mel, thanks for the response. I'll take a look at your previous PRs and we can discuss later about the endpoints. It still doesn't answer my concern 'The user object always validates a zipcode presence, therefore there will never be a user without a zipcode. Either we take out that validation, or frontend creates an error message when someone who is not logged in tries to enter a zipcode'. Also, I see that there is no merge conflicts but tests are failing. |
We can discuss this more at our meeting today! : ) |
| puzzles = Puzzle.where(user_id: users.pluck(:id)) | ||
| render json: PuzzleSerializer.new(puzzles) | ||
| elsif puzzles == [] || users = [] | ||
| render json: { error: "Puzzles not found in this area" }, status: "404" |
There was a problem hiding this comment.
This error handling works for now to meet MVP within our time limitation. But in a refactor we'll want to get this working through the ErrorSerializer. : )
|
|
||
| zip_code = params[:zip_code] | ||
|
|
||
| users = User.where(zip_code: zip_code) if zip_code.present? |
There was a problem hiding this comment.
This logic should probably be a method in the models and only called on here in the controller. But again, to meet MVP within out time limits let's just roll with it for now. Nice work.
| expect(parsed_data[:data][0][:attributes][:notes]).to eq(puzzle_1.notes) | ||
| expect(parsed_data[:data][0][:attributes][:puzzle_image_url]).to eq(puzzle_1.puzzle_image_url) | ||
|
|
||
| # NOTE Could refactor tests to not see a puzzle_4 in the test because it's in a diff zipcode |
There was a problem hiding this comment.
Excellent note here. And I agree that there should be a test to confirm no "stray" puzzles are found in a call for a specific zip_code.
|
|
||
| expect(parsed_error_data).to be_a(Hash) | ||
| expect(parsed_error_data.keys).to eq([:error]) | ||
| expect(parsed_error_data[:error]).to eq("Puzzles not found in this area") |
There was a problem hiding this comment.
And these tests would change once we use the ErrorSerializer in a refactor.
Changes:
This is related to # 3
This closes #
[] I linted my work. (RuboCop)
[] I've updated documentation & README. (if necessary)
(For Fun!) Please include a link to a meme/gif of your feelings about this branch!
Link:
Notes: The user object always validates a zipcode presence, therefore there will never be a user without a zipcode. Either we take out that validation, or frontend creates an error message when someone who is not logged in tries to enter a zipcode.
Didn;t add tests yet due to wanting confirmation on this issue.