Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read/unread status #1376

Merged
merged 26 commits into from
Apr 17, 2024
Merged

feat: read/unread status #1376

merged 26 commits into from
Apr 17, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jan 31, 2024

Proposed documentation for the read/unread support in Web3Inbox. This feature has not been implemented yet, but the documentation here should be accurate to what will be built.

Open questions:

  • markAsUnread
  • UpdateNotificationsReadState vs markNotificationAsRead

Remaining work:

  • iOS docs
  • Complete changelog page
  • Feature implementation

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walletconnect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm
walletconnect-docs-alpha ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm

* chore: add api for read unread

* chore: remove all flag

* chore: add docs for vanilla

* chore: change mark as read to promise

* Update docs/api/notify/usage.mdx

Co-authored-by: Chris Smith <[email protected]>

* Update docs/web3inbox/frontend-integration/api.mdx

Co-authored-by: Chris Smith <[email protected]>

* chore: avoid negatives

* chore: add docs for react native

---------

Co-authored-by: Chris Smith <[email protected]>
Copy link
Member Author

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devceline look good?

docs/web3inbox/frontend-integration/api.mdx Outdated Show resolved Hide resolved
docs/web3inbox/frontend-integration/api.mdx Outdated Show resolved Hide resolved
docs/web3inbox/frontend-integration/api.mdx Outdated Show resolved Hide resolved
docs/web3inbox/frontend-integration/api.mdx Outdated Show resolved Hide resolved
docs/web3wallet/notify/usage.mdx Outdated Show resolved Hide resolved
@chris13524 chris13524 marked this pull request as ready for review April 15, 2024 21:04
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris13524
Copy link
Member Author

Wallet support extracted into a separate PR since it has not been implemented yet: #1535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants