-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match identity key specs #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since this is a breaking change/major version bump, we should really wait for specs to merge before releasing this on latest
/merging this into master
.
Else we may end up rebumping major version here if something else changes in spec last minute.
Can of course already use this via canaries in the meantime if necessary 👍
My thinking exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👌
Changes
Make identity keys use domain of external dapp and accept a statement.
Match the following specs: WalletConnect/walletconnect-specs#138 and WalletConnect/walletconnect-specs#139