Match identity key specs #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrem
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM, since this is a breaking change/major version bump, we should really wait for specs to merge before releasing this on latest/merging this into master.
Else we may end up rebumping major version here if something else changes in spec last minute.
Can of course already use this via canaries in the meantime if necessary 👍
My thinking exactly |
Cali93
requested changes
Sep 18, 2023
Cali93
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make identity keys use domain of external dapp and accept a statement.
Match the following specs: WalletConnect/walletconnect-specs#138 and WalletConnect/walletconnect-specs#139