Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/eip1271 support #445

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Feat/eip1271 support #445

merged 6 commits into from
Feb 27, 2024

Conversation

devceline
Copy link
Collaborator

@devceline devceline commented Feb 21, 2024 •
edited
Loading

Description

  • Bump notify client & identity keys to support eip1271
  • Add detection for smart contract wallets using bytecode
  • assume a smart contract has eip1271 signature

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Fixes/Resolves (Optional)

Resolves #430

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 9:11pm

chris13524
chris13524 reviewed Feb 21, 2024
View reviewed changes
src/w3iProxy/index.ts Outdated Show resolved Hide resolved
chris13524
chris13524 reviewed Feb 21, 2024
View reviewed changes
src/w3iProxy/index.ts Outdated Show resolved Hide resolved
@devceline devceline marked this pull request as ready for review February 26, 2024 14:48
@devceline devceline merged commit 32d70f8 into main Feb 27, 2024
3 checks passed
@devceline devceline deleted the feat/eip1271-support branch February 27, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@enesozturk enesozturk Awaiting requested review from enesozturk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-1271 support
2 participants
@devceline @chris13524