Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

#643 updating the twitter logo #644

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sourav-Kumar-Panda
Copy link

@Sourav-Kumar-Panda Sourav-Kumar-Panda commented Sep 27, 2023

Updating the twitter logo.
issue no. #643

@coderabbitai
Copy link

coderabbitai bot commented Sep 27, 2023

Walkthrough

The change is a simple yet effective one, involving the source of the Twitter logo image in the README.md file. The previous external vector logo has been replaced with a local SVG file, enhancing control and reliability.

Changes

File Summary
README.md Replaced the source of the Twitter logo from an external vector logo to a local SVG file named "icons8-twitterx.svg".

🐇💻

A tiny tweak, a minor move,

In the codebase groove.

From afar to near we shift,

Giving our logo a lift.

No more reliance on distant site,

Now our Twitter icon's light!

So here's to changes, big and small,

CodeRabbit celebrates them all! 🎉🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between b6f12e2 and fdcc0c1.
Files ignored due to filter (1)
  • icons8-twitterx.svg
Files selected for processing (1)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • README.md

Copy link
Contributor

@rahulpandey70 rahulpandey70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide screenshot?
Rest looks good.

@Sourav-Kumar-Panda
Copy link
Author

Screenshot 2023-09-27 143439
If there are any changes required, let me know.
Thank You.

@rahulpandey70
Copy link
Contributor

Screenshot 2023-09-27 143439 If there are any changes required, let me know. Thank You.

Look good, but i think i was taking about website WeMakeDevs twitter icon.

@Sourav-Kumar-Panda
Copy link
Author

Screenshot 2023-09-27 143439 If there are any changes required, let me know. Thank You.

Look good, but i think i was taking about website WeMakeDevs twitter icon.

You should mention this issue in the WemakeDevs repo, not in the roadmap repo.
Here you did not mention about the website, you just said "Need to change the twitter icon" in Issue no. #643

@rahulpandey70
Copy link
Contributor

Screenshot 2023-09-27 143439 If there are any changes required, let me know. Thank You.

Look good, but i think i was taking about website WeMakeDevs twitter icon.

You should mention this issue in the WemakeDevs repo, not in the roadmap repo. Here you did not mention about the website, you just said "Need to change the twitter icon" in Issue no. #643

You're right, i should open this issue in WeMakeDevs repo.

@Sourav-Kumar-Panda
Copy link
Author

So will this PR will merged or not?

@rahulpandey70
Copy link
Contributor

So will this PR will merged or not?

Let's wait for the maintainer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants