Skip to content

Commit

Permalink
Merge pull request #563 from fitzgen/array-new-elem-out-of-bounds-tests
Browse files Browse the repository at this point in the history
Test out-of-bounds element segment indexing for `array.new_elem`
  • Loading branch information
rossberg authored Sep 29, 2024
2 parents a765a6d + b889c63 commit e878982
Showing 1 changed file with 103 additions and 0 deletions.
103 changes: 103 additions & 0 deletions test/core/gc/array_new_elem.wast
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
;;;; Expression-style element segments.

(module
(type $arr (array i31ref))

(elem $e i31ref
(ref.i31 (i32.const 0xaa))
(ref.i31 (i32.const 0xbb))
(ref.i31 (i32.const 0xcc))
(ref.i31 (i32.const 0xdd)))

(func (export "array-new-elem") (param i32 i32) (result (ref $arr))
(array.new_elem $arr $e (local.get 0) (local.get 1))
)
)

;; In-bounds element segment accesses.
(assert_return (invoke "array-new-elem" (i32.const 0) (i32.const 0)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 0) (i32.const 4)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 1) (i32.const 2)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 4) (i32.const 0)) (ref.array))

;; Out-of-bounds element segment accesses.
(assert_trap (invoke "array-new-elem" (i32.const 0) (i32.const 5)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 5) (i32.const 0)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 1) (i32.const 4)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 4) (i32.const 1)) "out of bounds table access")

(module
(type $arr (array i31ref))

(elem $e i31ref
(ref.i31 (i32.const 0xaa))
(ref.i31 (i32.const 0xbb))
(ref.i31 (i32.const 0xcc))
(ref.i31 (i32.const 0xdd)))

(func (export "array-new-elem-contents") (result i32 i32)
(local (ref $arr))
(local.set 0 (array.new_elem $arr $e (i32.const 1) (i32.const 2)))
(i31.get_u (array.get $arr (local.get 0) (i32.const 0)))
(i31.get_u (array.get $arr (local.get 0) (i32.const 1)))
)
)

;; Array is initialized with the correct contents.
(assert_return (invoke "array-new-elem-contents") (i32.const 0xbb) (i32.const 0xcc))

;;;; MVP-style function-index segments.

(module
(type $arr (array funcref))

(elem $e func $aa $bb $cc $dd)
(func $aa (result i32) (i32.const 0xaa))
(func $bb (result i32) (i32.const 0xbb))
(func $cc (result i32) (i32.const 0xcc))
(func $dd (result i32) (i32.const 0xdd))

(func (export "array-new-elem") (param i32 i32) (result (ref $arr))
(array.new_elem $arr $e (local.get 0) (local.get 1))
)
)

;; In-bounds element segment accesses.
(assert_return (invoke "array-new-elem" (i32.const 0) (i32.const 0)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 0) (i32.const 4)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 1) (i32.const 2)) (ref.array))
(assert_return (invoke "array-new-elem" (i32.const 4) (i32.const 0)) (ref.array))

;; Out-of-bounds element segment accesses.
(assert_trap (invoke "array-new-elem" (i32.const 0) (i32.const 5)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 5) (i32.const 0)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 1) (i32.const 4)) "out of bounds table access")
(assert_trap (invoke "array-new-elem" (i32.const 4) (i32.const 1)) "out of bounds table access")

(module
(type $f (func (result i32)))
(type $arr (array funcref))

(elem $e func $aa $bb $cc $dd)
(func $aa (result i32) (i32.const 0xaa))
(func $bb (result i32) (i32.const 0xbb))
(func $cc (result i32) (i32.const 0xcc))
(func $dd (result i32) (i32.const 0xdd))

(table $t 2 2 funcref)

(func (export "array-new-elem-contents") (result i32 i32)
(local (ref $arr))
(local.set 0 (array.new_elem $arr $e (i32.const 1) (i32.const 2)))

(table.set $t (i32.const 0) (array.get $arr (local.get 0) (i32.const 0)))
(table.set $t (i32.const 1) (array.get $arr (local.get 0) (i32.const 1)))

(call_indirect (type $f) (i32.const 0))
(call_indirect (type $f) (i32.const 1))

)
)

;; Array is initialized with the correct contents.
(assert_return (invoke "array-new-elem-contents") (i32.const 0xbb) (i32.const 0xcc))

0 comments on commit e878982

Please sign in to comment.