Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary support for Google Cloud Translation Advanced #12777

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gersona
Copy link
Collaborator

@gersona gersona commented Oct 15, 2024

Proposed changes

Added optional glossary support for Google v3 automatic suggestions.
Notable changes include:

  • New bucket_name field for GoogleV3MachineryForm settings form
  • New optional dependency google-cloud-storage

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

fixes #10526

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 98.92473% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.19%. Comparing base (7a1cbae) to head (7fcf098).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
weblate/machinery/googlev3.py 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12777      +/-   ##
==========================================
+ Coverage   91.18%   91.19%   +0.01%     
==========================================
  Files         596      596              
  Lines       61149    61237      +88     
  Branches     6345     6347       +2     
==========================================
+ Hits        55758    55846      +88     
+ Misses       3740     3739       -1     
- Partials     1651     1652       +1     
Files with missing lines Coverage Δ
weblate/machinery/forms.py 96.29% <100.00%> (+0.03%) ⬆️
weblate/machinery/tests.py 99.67% <100.00%> (+0.01%) ⬆️
weblate/machinery/googlev3.py 93.75% <97.43%> (+2.84%) ⬆️

... and 1 file with indirect coverage changes

@gersona gersona marked this pull request as ready for review October 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary support for Google Cloud Translation Advanced
1 participant