feat: quote audit log values to avoid auto linking #12780
Merged
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some e-mail services such as Gmail automatically convert things that look like a link into links even in HTML mails. This could be problematic for audit log entries as want to display the information as is without turning that into links. Adding <span> seems to help in this according to https://stackoverflow.com/a/23404042/225718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some e-mail services such as Gmail automatically convert things that look like a link into links even in HTML mails. This could be problematic for audit log entries as want to display the information as is without turning that into links.
Adding
<span>seems to help in this according to https://stackoverflow.com/a/23404042/225718Checklist
Other information