secureCodeBox#121 Remove Unused field from Intermediate Class

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf · Jul 3, 2024 · f5ff0ae · f5ff0ae
1 parent 814d455
commit f5ff0ae
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java b/src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java
@@ -4,7 +4,6 @@
 
 package io.securecodebox.persistence.defectdojo.http;
 
-import io.securecodebox.persistence.defectdojo.config.Config;
 import lombok.NonNull;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.http.HttpHost;
@@ -18,12 +17,10 @@
  */
 @Slf4j
 public final class Foo {
-  private final Config config;
   private final ProxyConfig proxyConfig;
 
-  public Foo(@NonNull final Config config, @NonNull final ProxyConfig proxyConfig) {
+  public Foo(@NonNull ProxyConfig proxyConfig) {
     super();
-    this.config = config;
     this.proxyConfig = proxyConfig;
   }
 

diff --git a/src/main/java/io/securecodebox/persistence/defectdojo/service/GenericDefectDojoService.java b/src/main/java/io/securecodebox/persistence/defectdojo/service/GenericDefectDojoService.java
@@ -186,7 +186,7 @@ private HttpHeaders getDefectDojoAuthorizationHeaders() {
   }
 
   private RestTemplate setupRestTemplate() {
-    RestTemplate restTemplate = new Foo(config, new ProxyConfigFactory().create()).createRestTemplate();
+    RestTemplate restTemplate = new Foo(new ProxyConfigFactory().create()).createRestTemplate();
     MappingJackson2HttpMessageConverter converter = new MappingJackson2HttpMessageConverter();
     converter.setObjectMapper(this.objectMapper);
     restTemplate.setMessageConverters(List.of(

diff --git a/src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService2.java b/src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService2.java
@@ -54,7 +54,7 @@ private HttpHeaders getDefectDojoAuthorizationHeaders() {
   }
 
   protected RestTemplate setupRestTemplate() {
-    return new Foo(config, new ProxyConfigFactory().create()).createRestTemplate();
+    return new Foo(new ProxyConfigFactory().create()).createRestTemplate();
   }
 
   /**

diff --git a/src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java b/src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java
@@ -16,14 +16,13 @@
  * Tests for {@link Foo}
  */
 class FooTest {
-  private final Config config = new Config("url", "apikey");
   private final ProxyConfig proxyConfig = ProxyConfig.builder()
     .user("user")
     .password("pw")
     .host("host")
     .port(42)
     .build();
-  private final Foo sut = new Foo(config, proxyConfig);
+  private final Foo sut = new Foo(proxyConfig);