Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the website look cool and modern. #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the website look cool and modern. #39

wants to merge 1 commit into from

Conversation

JoshuaBrest
Copy link
Contributor

1

2

@JoshuaBrest
Copy link
Contributor Author

Fixed!
1
2

IsaacMarovitz
IsaacMarovitz requested changes May 18, 2024
View reviewed changes
Copy link
Member

@IsaacMarovitz IsaacMarovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments

theme/index.hbs Show resolved Hide resolved
theme/fonts/fonts.css Show resolved Hide resolved
theme/css/chrome.css Outdated Show resolved Hide resolved
@hahayupgit hahayupgit added the docs enhancement New feature or request label Jul 11, 2024
@JoshuaBrest
Copy link
Contributor Author

crap, what did i just do 💀

@JoshuaBrest
Copy link
Contributor Author

CleanShot 2024-10-17 at 20 46 50@2x
CleanShot 2024-10-17 at 20 45 58@2x

IsaacMarovitz
IsaacMarovitz requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@IsaacMarovitz IsaacMarovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small design tweaks:

  1. Make the sidebar a little less wide
  2. Reduce some of the sidebar padding
  3. Add back the sidebar numbering
  4. Scrolling on the main view messes with sidebar (see video for comparison)
  5. I kind of prefer the old font to this one
  6. Make "docs" capitalised and "whisky" capitalised in search placeholder

Old Design:
https://github.com/user-attachments/assets/52c21799-ea93-4642-9aa5-7a3b52ea46e3

New Design:
https://github.com/user-attachments/assets/22989e21-9ff4-45ce-82a1-10687dfad656

  • Sidebar clips into header
  • Brown HTML background still visible

@hahayupgit hahayupgit added the question/awaiting changes Further information is requested label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacMarovitz IsaacMarovitz IsaacMarovitz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
docs enhancement New feature or request question/awaiting changes Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaBrest @IsaacMarovitz @hahayupgit