Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/osmosis fee 1e 3 #377

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Fix/osmosis fee 1e 3 #377

merged 5 commits into from
Sep 2, 2024

Conversation

nseguias
Copy link
Contributor

Description and Motivation

This PR validates that on pool creation, the osmosis swap fee is set to 0.001

Related Issues

#375


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

@nseguias nseguias changed the base branch from main to release/v2_contracts August 16, 2024 09:25
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (2f40957) to head (e685099).
Report is 4 commits behind head on release/v2_contracts.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #377      +/-   ##
========================================================
+ Coverage                 90.90%   90.93%   +0.02%     
========================================================
  Files                       280      280              
  Lines                     31830    31915      +85     
========================================================
+ Hits                      28936    29022      +86     
+ Misses                     2894     2893       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x merged commit 0611928 into release/v2_contracts Sep 2, 2024
3 of 5 checks passed
@kerber0x kerber0x deleted the fix/osmosis-fee-1e-3 branch September 2, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants