Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beforePin and beforeUnpin actions #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uhlenbrock
Copy link

Fixes #96.

@WickyNilliams
Copy link
Owner

I'm still not sure about this. Don't want to complicate the API further with more callbacks, yet i can see the need/desire for this kind of functionality. I'll think it over this week (I plan on getting through as many issues/PRs as possible this week)

@lucasconstantino
Copy link

I like the idea, but I would find it better with an event based implementation. Something that would allow you to prevent the default, which would be the pin/unpin effect.

@EnigmaSolved
Copy link

I'd love to see this merged as I too have a need for this functionality. In general I am also a fan of event-based approaches, but the callbacks get the job done just fine. :) If you were to switch to event-based it would be best to do that for all callbacks, which obviously would be a significant change, and thus one I recommend leaving until some future date (ie, go ahead and introduce the beforePin, beforeUnpin callbacks, and explore a possible events overhaul later).

@zebapy
Copy link

zebapy commented Mar 23, 2020

I also could use this and will have to find a workaround in the mean time.

@zebapy
Copy link

zebapy commented Jul 31, 2020

@WickyNilliams anything we can help with to get this in? I need this yet again on a different project now. It's been awhile, it might as well get merged then later handle the event emitter changes when those come around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom functions to determine whether or not to pin/unpin headroom element
5 participants