Minor change to enable calling apps to be aware of exceptions #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eek. I'm nowhere near experienced enough to know why github's saying it failed. It passed the tests when I ran them through maven on the command line. |
|
It's not related to your PR, it's my own fault, the submission of coverage info fails because your PR was opened from a fork, which disables secrets in the workflow for security reasons. I'll get this fixed independently. |
|
Phew! That's good to know. |
Does not work anymore with GitHub CI
This reverts commit b867a2a. We will add the integration back!
|
Closing as replaced by #526. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The of processDumpFile() method of DumpProcessingController was catching exceptions, so calling apps couldn't detect whether an error had occurred. This minor change modifies processDumpFile() to throw exceptions with their original error message after logging them with their original log message.