Add support for items in shortcuts addon. #2076

Imisnew2 · 2021-09-02T04:23:10Z

Adds support for items so that /<item name> causes that item to be used -- i.e. translates to /item "<item name>" <me>.

Test cases:
/remedy
/rolandaifuku
/rolandaifuku+1

This is intended to allow quotes to be omitted when using brackets`[]` in the equip command. This allows the command to function properly when double quites are used. The following should now all work: gs equip precast.WS["Rudra's Storm"] gs equip precast.WS['Rudra's Storm'] gs equip precast.WS[Rudra's Storm] gs equip precast.WS.Rudra's Storm While I'm at it, the function also would only ever exit after 30 iterations. This is now fixed.

Adding Chaosbringer to the list of checkable weapons (DRK flag quest weapon)

Adding Chaosbringer

Added new items to Slip 22

Update slips.lua

Added Mastery Rank to 0x01B and an unknown/junk field to 0x061

This is to add back the synthesis results that are lost on the injected synths.

Added resize and reset commands, implemented IPC, cleaned up code.

Update README.md

Got rid of windower.ffxi.get_info() and .get_player() calls.

Added Cumulus Masque +1

Updated to version 2.0

Update craft.lua

Mastery Rank

Update/Fix slips.lua lib

Update slips.lua

Upgrade EmpyPopTracker to 2.5.0

Fix use of quotes in `gs equip` and exit loop properly

Update message_ids.lua

JobChange: Added command to change both jobs at once and prefer dw subjobs on reset

`incoming 0x017` changed to have different data for different chat modes Also tweaked `incoming 0x01B` for Mastery Rank and Mentor icon data

Update setbgm.lua

…strosity-fix Gearswap shortcuts monstrosity fix

Locals, spacing dev table, format arg, no more length the rest of the owl

A few functions for decoding dialog entries

change based on CHA CHA CHA's info

fixed comment numbering for 0x01C

Master Levels Update 1

variable fix

Adding Chemistry Set and Goujian to Slips library

Slips lib Update

[thtracker] variable fix

Changed to use boolbits and added Master Levels menu display data

Change to use Refs

Re-add Master flags comment

spacing fix

Update Master Level 2

Byrth

Looks good. Just a few questions.

Byrth · 2021-12-21T14:36:07Z

addons/shortcuts/statics.lua

        -- Monster Abilities contains a large number of player-usable moves (but not monstrosity-usable). This excludes them.
-            make_abil(strip(v.english),resource,id)
+            local name = resource ~= 'items' and strip_non_alphanumeric_convert_digits_to_roman(v.english) or strip_non_alphanumeric_keep_plus(v.english)


Are there name collisions if you don't keep the plus and avoid converting digits to roman numerals?

I didn't try, but I felt /rolandaifuku+1 felt more natural than /rolandaifuku1.

That's fine, but you can use /rolandaifuku+1 either way.

My main concern here is that this adds complexity (two slug paths) without adding any obvious benefit.

No. If we only used the original, it would be simply /rolandaifuku for both the normal and +1 versions: the plus gets stripped and the 1 gets omitted when converting to Roman numerals.

Byrth · 2021-12-21T14:37:31Z

addons/shortcuts/statics.lua

@@ -198,9 +198,10 @@ end
 -- Iterate through resources and make validabils.
 function validabils_it(resource)
    for id,v in pairs(res[resource]) do
-        if (not v.monster_level and v.prefix) or (v.monster_level and v.monster_level ~= -1 and v.ja:sub(1,1) ~= '#' ) then
+        if (not v.monster_level and v.prefix) or (v.monster_level and v.monster_level ~= -1 and v.ja:sub(1,1) ~= '#' ) or (v.category == 'Usable') then


This seems okay to me. If someone wants to revisit this decision, they can do it in another PR.

Byrth · 2021-12-21T14:39:10Z

addons/shortcuts/shortcuts.lua


-aliases = config.load('data\\aliases.xml',default_aliases)
+aliases = config.load('data/aliases.xml', default_aliases)
+settings = config.load('data/settings.xml', default_settings)


Adding another settings file just to allow people to disable compatibility with items seems like a lot of work for no obvious benefit. I would just make it an always-on feature. No one is going to accidentally type //proether+3 or //vileelixir+1

I did this because of vague concerns that this would cause problems. https://discord.com/channels/338590234235371531/501099842097905675/883160617706483712

This adds complexity without benefit, so I would eliminate it. Make items always-on and don't add a settings file.

RubenatorX and others added 30 commits December 28, 2020 16:22

Adding Chaosbringer

6426cd0

Adding Chaosbringer to the list of checkable weapons (DRK flag quest weapon)

Merge pull request Windower#1984 from lili-ffxi/patch-4

f09151f

Adding Chaosbringer

Update slips.lua

c70e4b3

Added new items to Slip 22

Merge pull request Windower#1986 from Hadin1/patch-1

c4c160b

Update slips.lua

jan update changes

dda6ca3

Mastery Rank

29d6a0e

Added Mastery Rank to 0x01B and an unknown/junk field to 0x061

Update craft.lua

194ceff

This is to add back the synthesis results that are lost on the injected synths.

Updated to version 2.0

a2b045b

Added resize and reset commands, implemented IPC, cleaned up code.

Update README.md

8582160

Merge pull request Windower#1992 from lili-ffxi/patch-6

425df84

Update README.md

Code cleanup

8f17534

Got rid of windower.ffxi.get_info() and .get_player() calls.

Last second copypaste bug squash.

be55431

Update craft.lua

16b3499

Added Cumulus Masque +1

de61b2d

Update Dimmer.lua

78fe1d2

Less spaces

cbe51ae

Merge pull request Windower#1993 from lili-ffxi/patch-7

5512a80

Added Cumulus Masque +1

Merge pull request Windower#1991 from lili-ffxi/patch-5

8372e24

Updated to version 2.0

Merge pull request Windower#1990 from ianandersonlol/patch-4

ceb9ef2

Update craft.lua

Merge pull request Windower#1989 from RubenatorX/patch-10

63c294d

Mastery Rank

Update slips.lua

5b8e331

Update/Fix slips.lua lib

Merge pull request Windower#1995 from KenshiDRK/dev

83073da

Update slips.lua

Merge pull request Windower#1947 from xurion/dev

f8d4bc4

Upgrade EmpyPopTracker to 2.5.0

Merge pull request Windower#1983 from RubenatorX/patch-9

2d77f3e

Fix use of quotes in `gs equip` and exit loop properly

Update message_ids.lua

7f19856

Merge pull request Windower#1996 from dtw/pointwatch-jan21

b57d448

Update message_ids.lua

Merge pull request Windower#1871 from AkadenTK/addons/jobchange

46caf0d

JobChange: Added command to change both jobs at once and prefer dw subjobs on reset

Yush: Added function support

b42bd9e

Packets fields.lua incoming 0x017 and 0x01B for Assist Channels

c0bcc0e

`incoming 0x017` changed to have different data for different chat modes Also tweaked `incoming 0x01B` for Mastery Rank and Mentor icon data

Byrth and others added 25 commits September 15, 2021 22:07

version bumps

82e6653

Merge pull request Windower#2079 from funkworkz/patch-2

5a233e8

Update setbgm.lua

Merge pull request Windower#2080 from Windower/gearswap-shortcuts-mon…

00cbce7

…strosity-fix Gearswap shortcuts monstrosity fix

A few functions for decoding dialog entries

02f95fa

Locals, spacing dev table, format arg, no more length the rest of the owl

Update messages and Add Low/Mid D Tower to be extracted

f04b053

Merge pull request Windower#2081 from trv6/dialog

b2ab69c

A few functions for decoding dialog entries

change based on CHA CHA CHA's info

84cc1a7

Merge pull request Windower#2084 from Windower/adjust_0x01C_incoming

e4432cf

change based on CHA CHA CHA's info

fixed comment numbering for 0x01C

566a726

Merge pull request Windower#2085 from Windower/fix_comment_numbering

ea338e4

fixed comment numbering for 0x01C

Update README.md

394ebfb

Master Levels Update 1

f774195

Merge pull request Windower#2091 from RubenatorX/patch-12

60e1e9b

Master Levels Update 1

[thtracker] variable fix

0023a17

variable fix

Slips lib Update

411d14f

Adding Chemistry Set and Goujian to Slips library

Merge pull request Windower#2093 from KenshiDRK/Slips

21b32bd

Slips lib Update

Merge pull request Windower#2092 from KenshiDRK/Thtracker

657bd2d

[thtracker] variable fix

Fix dupe label

6e2dbc3

Update Master Level 2

5ade870

Changed to use boolbits and added Master Levels menu display data

Master Levels Update 2

22b865b

Change to use Refs

Master Level Update 2

ffa2cce

Re-add Master flags comment

Master Level Update 2

cf18fa9

spacing fix

Merge pull request Windower#2096 from RubenatorX/patch-15

39d50b3

Update Master Level 2

the table's hex keys are interpreted as unsigned

7620dd2

Add support for items in shortcuts addon.

410cd5e

Imisnew2 force-pushed the dev branch from 911fc7b to 410cd5e Compare November 24, 2021 21:50

Byrth self-requested a review December 21, 2021 14:35

Byrth reviewed Dec 21, 2021

View reviewed changes

Traelblaser mentioned this pull request May 5, 2024

[shortcuts] add support for items #2354

Open

z16 force-pushed the dev branch from 9519dc7 to 5b7ed89 Compare November 4, 2024 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for items in shortcuts addon. #2076

Add support for items in shortcuts addon. #2076

Imisnew2 commented Sep 2, 2021

Byrth left a comment

Byrth Dec 21, 2021

Imisnew2 Dec 23, 2021

Byrth Jan 13, 2022

Byrth Jan 13, 2022

Imisnew2 Jan 13, 2022

Byrth Dec 21, 2021

Byrth Dec 21, 2021

Imisnew2 Dec 23, 2021

Byrth Jan 13, 2022

Add support for items in shortcuts addon. #2076

Are you sure you want to change the base?

Add support for items in shortcuts addon. #2076

Conversation

Imisnew2 commented Sep 2, 2021

Byrth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment