-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mountmuzzle] support custom BGM per mount #2351
Open
posimagi
wants to merge
1,574
commits into
Windower:dev
Choose a base branch
from
posimagi:mountmuzzle-custom-bgm
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yush: Added a VerboseKeys setting to enable key display in each macro set.
There is no spell called "Lightning Threnody"
0x0E8 is an outgoing packet.
[fields lib] fix wrong 0x0E8 packet direction
Added items to slips libs for the 10 June, 2022 FFXI Update.
[Slips lib] Update for June 2022
Allows users to toggle the draggable flag post-creation. Previously, this flag could only be passed in with the config in a images.new(config).
Adds the texts:draggable() function
Added Current TVR Mission.
Correct TVR `_junk` field.
Update fields.lua
Added items to slips libs for the 10 July, 2022 FFXI Update.
[Slips lib] Update for July 2022
Slips update
Adding items to slips from the august 10 update
[slips lib] August 10, 2022 FFXI Update
Song name released via ffxi official YouTube channel video
Update setbgm.lua
Update EmpyPopTracker to 2.7.0
Strings isn't required
Remove strings method from libs/dialog
Added definition for which bag the linkshell is being equipped from.
Update fields.lua: Update 0x0E0 (Linkshell Equip)
Forgot some quotes because of course I did.
Adding Arrogance set to the Storage slips 31
[Slips] Adding June 2024 FFXI update item
In-game, /bstpet accepts both a number (an index of the pet move to perform) or the full name of the desired move. Previously gearswap would only trigger when the index was provided and now with the full name. This change fixes triggers.lua to trigger gearswap when /bstpet is used with the pet ability name.
* Update strings.lua Include ffxi's specific color codes and autotranslate delimiters * Update strings.lua More tweaks to characters, and restore trailing empty token.
Fixes following the changes to strings library.
Somehow somewhen these fields have been shuffled. Now they're fixed.
Fixes texts.hover when text is right justified
Adding Apathy and Rage sets to Storage Slips 31.
[Slips] Adding July and August Updates
Update to dynamically add storage slips
[FindAll] Update to dynamically add storage slips
Fix for instances
…damage (Windower#2370) Scoreboard would overflow and display a negative number once the total amount of damage dealt was over 2^32. Changing `%d` for `%.0f` where appropriate to avoid this.
…wer#2371) * Parse last_incoming packets in chronological order. Previously gearswap would present stale player data right upon loading, due to reading last_incoming packets out of chronological order. This commit fixes that. * Version bump. * Fix potential timestamp clash Rewrote the function to prevent issues in case of two packets having the same timestamp.
* Update labels on Item flags 02 and 03 As per Windower/POLUtils#25 I am not sure about naming (tho these match the labels used on BG-Wiki, and I think LSB too), opinions appreciated. * Rename Flag00 to Wall-mounted. Using `Wall-mounted` because that's what FFXIV calls these.
Add augment values for "pet: PDT" and "pet: MDT" on Ambuscade capes
* Update statics.lua * Update gearswap.lua
Adding Cowardice set to storage slips 31
[Slips] Adding September 2024 FFXI update items
Co-authored-by: Serena <[email protected]>
Adding Envy set to storage slips 31
This fix the Fighting Stances moves to show the greek letters.
* [Shortcuts] Fix for Monstrosity Fighting Stances This allow the use of Fighting Stance commands in monstrosity through shortcuts. * Update shortcuts.lua
posimagi
force-pushed
the
mountmuzzle-custom-bgm
branch
from
October 14, 2024 09:50
4eff7ec
to
8f799c6
Compare
Updated to address comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to set MountMuzzle BGM per mount per https://www.ffxiah.com/forum/topic/37379/lua-addon-ideas/29/#3700676.
New commands:
//mm set custom
(alias://mm s u
, for "user", to avoid conflict with "chocobo")//mm c[ustom] MountName TrackNumber
Features: