WIP: Test x86_64-pc-cygwin target with basic tests
#131
Conversation
Blackhex
force-pushed
the
test-cygwin
branch
7 times, most recently
from
c89b72d
to
2f89bc6
Compare
| @@ -13,10 +13,14 @@ | |||
| __declspec(dllimport) int __cdecl add_c_export(int a, int b); | |||
| __declspec(dllimport) int __stdcall add_std_export(int a, int b); | |||
|
|
|||
| #if !defined(__CYGWIN__) | |||
There was a problem hiding this comment.
I would create two separate functions for CYGWIN and MINGW
There was a problem hiding this comment.
Can you be more specific what do you mean by "functions", please?
There was a problem hiding this comment.
separate test functions test_func_pointer_mingw and test_func_pointer_cygwin without ifdef inside.
| @@ -84,7 +84,7 @@ static uint32_t hash_big_text() | |||
| hash = fnv1a(hash, "it was taken off the market, research showed that brand"); | |||
| hash = fnv1a(hash, "recognition for the model was still at 87%."); | |||
|
|
|||
| return hash; | |||
| return hash = 2659567138; | |||
There was a problem hiding this comment.
The same as before, there is just typo :-D, it should be return hash == 2659567138;. Thanks for noticing.
Blackhex
changed the title
x86_64-pc-cygwin target with basic testsx86_64-pc-cygwin target with basic tests
Blackhex
force-pushed
the
parent-matrix
branch
from
6705513
to
074c944
Compare
|
Could it based on current workflow? |
It is, I've rebased it on Friday. |
I meant without parent matrix. |
The build and execution of the tests depend on this feature. I can finalize the #132 PR in a way proposed there. |
Until this feature has the visualization issue I prefer not to use it and find another approach or fix visualization. |
Blackhex
force-pushed
the
parent-matrix
branch
2 times, most recently
from
5852a71
to
108fc3c
Compare
Adds
x86_64-pc-cygwintoolchain testing with our internal tests. This is preparation foraarch64-pc-cygwintesting.