Verbose make #46
Verbose make #46
Conversation
.github/scripts/build-binutils.sh
Outdated
| @@ -4,7 +4,7 @@ BINUTILS_VERSION=${BINUTILS_VERSION:-binutils-master} | |||
|
|
|||
| TARGET=${TARGET:-aarch64-w64-mingw32} | |||
| BUILD_PATH=${BUILD_PATH:-$PWD/build-$TARGET} | |||
| BUILD_MAKE_OPTIONS=-j$(nproc) | |||
| BUILD_MAKE_OPTIONS=${BUILD_MAKE_OPTIONS:V=1 -j$(nproc)} | |||
There was a problem hiding this comment.
What about moving these almost the same settings out? Less changes for adjustment, less chances to forget something.
There was a problem hiding this comment.
The default value here serves only the purpose when the script is called alone, e.g. locally. Any suggestion how to kill those two birds with one stone?
There was a problem hiding this comment.
for instance to move BUILD_MAKE_OPTIONS to a separate bash script
include the script everywhere where it is needed.
Overwriting default value will be working the same way, however default value will be placed only in one place.
There was a problem hiding this comment.
OK, let me try whether this approach will be feasible. Thank you for the suggestion.
There was a problem hiding this comment.
The feedback adressed in the #49. This PR will be updated to contain only make options change once that one will be merged.
Blackhex
force-pushed
the
verbose-make
branch
from
72a9a97
to
f23735b
Compare
Makes make output verbose and allows overriding the
BUILD_MAKE_OPTIONSfrom outside of scripts.