Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow forcing host architeture #2

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Allow forcing host architeture #2

wants to merge 4 commits into from

Conversation

Blackhex
Copy link
Member

@Blackhex Blackhex commented Jan 20, 2023 •
edited
Loading

This change allows forcing host architecture for the compilation. When running vcbuild.bat inside x64 Python shell on Arm64 marchine, Python always overwrites PROCESSOR_ARCHITECTURE environment variable with AMD64.

Contributes to https://github.com/dotnet-microsoft/ARM-on-Windows-Ecosystem/issues/202

@Blackhex Blackhex self-assigned this Jan 20, 2023
eukarpov
eukarpov reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@eukarpov eukarpov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe python should we fixed instead then?

@Blackhex
Copy link
Member Author

Blackhex commented Jan 25, 2023 •
edited
Loading

Yeah, It would require further investigation on how the PROCESSOR_ARCHITECTURE=AMD64 gets to the x64 Conda Python interpreter  running on Arm64 machine enviroment as it does not seem to be set in CPython codebase. So far we can consider this PR as a temporary workaround.

pimterry and others added 4 commits January 30, 2023 11:27
@pimterry
http: keep HTTP/1.1 conns alive even if the Connection header is removed
2a29df6 
Previously persistence was completed disabled if you removed this
header, which is not correct for modern HTTP, where the header is
optional and all connections should persist by default regardless.

PR-URL: nodejs#46331
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@Blackhex
Allow forcing host architeture
4cae9c6
@Blackhex
Revert "Allow forcing host architeture"
e6c0f98 
This reverts commit 6d26d9d.
@Blackhex
Allow forcing host architeture
6b1655f
@Blackhex Blackhex marked this pull request as draft February 14, 2023 15:32
@Blackhex Blackhex changed the title Allow forcing host architeture [WIP] Allow forcing host architeture Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eukarpov eukarpov eukarpov left review comments

Assignees

@Blackhex Blackhex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackhex @eukarpov @pimterry