Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msxml3: added downloading dll with resources for 64-bit #2231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SurenIV
Copy link
Contributor

@SurenIV SurenIV commented May 30, 2024

Added downloading and copying msxml3r.dll in system32 for 64-bit prefixes.

src/winetricks Outdated
@@ -12002,7 +12002,9 @@ load_msxml3()

if [ "${W_ARCH}" = "win64" ]; then
helper_win7sp1_x64 amd64_microsoft-windows-msxml30_31bf3856ad364e35_6.1.7601.17514_none_e6944609ad75ac7d/msxml3.dll
w_download https://cloudflare-ipfs.com/ipfs/QmanVf9v1NDfBRieGmuHLNkZyoxndijitbTJxs9MyGVpCc?filename=msxml3r.dll 3efa5c3a8ee14c2de9f9ea5507a9950a0d991184dd723c79aca786e0b5fd7cf5 msxml3r.dll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like a reputable source (and also makes the verb out of sync with the 32-bit version).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the dll download so that the 64-bit installation would be more sync with the 32-bit one. Added a comment with information about what is being downloaded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't address the core issue. Taking a dll from windows and putting it on the internet violates Microsoft's copyright. We need a publicly redistributable binary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An article from https://mskb.pkisolutions.com/kb/973687 states that resources can be found in update KB973687.
This matches msxml 3.0 SP10 (for Vista SP1) https://learn.microsoft.com/en-us/previous-versions/troubleshoot/msxml/list-of-xml-parser-versions. The win7sp1 update contains a newer version of msxml3 and probably does not require the msxml3r.dll resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably does not require the msxml3r.dll resources.

I ran a couple of tests and made sure that msxml3r.dll was still needed. Because without it, installing some programs is impossible. I'll try to get the resource from the sources I indicated earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants