Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWZ-221 churn/refactor calculation #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ltvcuong
Copy link
Contributor

@ltvcuong ltvcuong commented Aug 3, 2020

What does this PR do?

  • script to determine churn/refactor with git show and git blame
  • update script to calculate modification not using diffstat tool

Where should the reviewer start?

Screenshots & link (if appropriate)

Questions

- script to determine churn/refactor with git show and git blame
- update script to calculate modification not using diffstat tool
@ltvcuong ltvcuong requested review from sang-d and npak243 August 3, 2020 02:48
Copy link
Contributor

@sang-d sang-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great!
I'm not proficient with awk so this is a good learning for me.
I think it will be good performance and fast but might be bit hard for maintenance for example writing test. Probably need a wrapper for testing.

- changes in package-lock.json and other json files are too big:
temporarily ignored *.json files
- execute sql insert every 10 commit mark to avoid too many values error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants