Overhaul the color scheme selection #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach was intended to provide a lot of flexibility at the cost of increased complexity and unsolved UI/UX challenges in regards to the toggle button. A major concern is the ability to easily access this switch on mobile devices that are incredibly space constrained and the page header offers insufficient space for an extra button.
It has its undeniable perks to switch the color scheme on the fly but this is still merely a gimmick and not very useful in day to day use. For example, developers can already dynamically override the color scheme through the browser’s developer tools. In addition the selection was stored in the local storage which not only causes multiple tabs to become out of sync but also causes a persistency issue when browsers are configured to flush the site’s data when the last tab are closed.
The new approach is much less “fancy”, but provides a consistent and accessible experience. The color scheme can now only be selected through the user settings and are stored on the server. Guests will always default to their device preference which reacts to dynamic changes, for example, during night time.