Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint for theme starter content option #77

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Conversation

bph
Copy link
Collaborator

@bph bph commented Nov 12, 2024

Fixed #60

  • Installs a theme with the option to install starter content, like Twenty-Twenty-One
  • User lands on the homepage
  • Add blueprint to gallery

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@bph bph self-assigned this Nov 12, 2024
@bph bph marked this pull request as draft November 12, 2024 20:18
@bph bph marked this pull request as ready for review November 12, 2024 21:18
Copy link
Contributor

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bph!

I left one small comment related to the JSON formatting.

Comment on lines +20 to +27
"options": {
"activate": true,
"importStarterContent": true
}
}

]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"options": {
"activate": true,
"importStarterContent": true
}
}
]
}
"options": {
"activate": true,
"importStarterContent": true
}
}
]
}

@adamziel
Copy link
Contributor

adamziel commented Nov 13, 2024

@bgrgicak thank you for reviewing here! Here's a cool thing – formatting issues are fine. There's an autoformatter running after merging each PR:

https://github.com/WordPress/blueprints/blob/trunk/.github/workflows/postprocess.yml

@adamziel adamziel merged commit 36e0dd5 into trunk Nov 13, 2024
2 checks passed
@bph bph deleted the startercontent branch November 15, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a blueprint for setting up a theme with some initial content (using "importThemeStarterContent")
3 participants