-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Black Bordered Radius Block Variation and Pattern About Page #211
Open
maurodf0
wants to merge
2
commits into
WordPress:trunk
Choose a base branch
from
maurodf0:trunk
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?php | ||
/** | ||
* Title: About | ||
* Slug: term/about | ||
* Categories: image, social, text | ||
*/ | ||
?> | ||
|
||
<!-- wp:group {"layout":{"type":"constrained"}} --> | ||
<div class="wp-block-group"><!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} --> | ||
<div class="wp-block-group"><!-- wp:image {"id":23,"sizeSlug":"full","linkDestination":"none","style":{"layout":{"selfStretch":"fit","flexSize":null}},"className":"is-style-black-border-radius is-style-bordered"} --> | ||
<figure class="wp-block-image size-full is-style-black-border-radius is-style-bordered"><img src="<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/happy-man.jpg" alt="" class="wp-image-23"/></figure> | ||
<!-- /wp:image --> | ||
|
||
<!-- wp:paragraph {"fontSize":"medium"} --> | ||
<p class="has-medium-font-size"><?php echo esc_html_x('Joel Gavins is a really interesting dude who writes about really interesting things. Haha PSYCH! He just babbles into a post editor hoping something good comes out of it, but we all know how that goes.', 'term'); ?></p> | ||
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:paragraph {"fontSize":"medium"} --> | ||
<p class="has-medium-font-size"><?php echo esc_html_x('In his real life, Joel Gavins is actually a tax accountant. True story. You might think it’s the most boring job in the world, but he’ll never go out of business! Taxes are so terribly confusing that everyone needs someone else to do their taxes, that’s the whole point of the industry. So while your job might get taken over by AI, lobbying will always ensure that Joel has a nice cushy job and a working Honda Civic.' , 'term'); ?></p> | ||
<!-- /wp:paragraph --> | ||
|
||
<!-- wp:heading {"level":6,"style":{"elements":{"link":{"color":{"text":"var:preset|color|custom-grey"}}}},"textColor":"custom-grey"} --> | ||
<h6 class="wp-block-heading has-custom-grey-color has-text-color has-link-color"><?php echo esc_html_x( 'FOLLOW ME ON', 'term' ); ?> </h6> | ||
<!-- /wp:heading --> | ||
|
||
<!-- wp:social-links {"iconColor":"custom-beige","iconColorValue":"#edece8","iconBackgroundColor":"custom-black","iconBackgroundColorValue":"#000","className":"is-style-square-rounded-social is-style-social-rounded-icons"} --> | ||
<ul class="wp-block-social-links has-icon-color has-icon-background-color is-style-square-rounded-social is-style-social-rounded-icons"><!-- wp:social-link {"url":"#","service":"facebook"} /--> | ||
|
||
<!-- wp:social-link {"url":"#","service":"instagram"} /--> | ||
|
||
<!-- wp:social-link {"url":"#","service":"twitter"} /--></ul> | ||
<!-- /wp:social-links --></div> | ||
<!-- /wp:group --></div> | ||
<!-- /wp:group --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this because we can already use the border controls on the image block. We only did it for the social icons because those controls are not there yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason being: a user can only opt in or out of the border radius, they can't tweak it to other values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, don't think about it, sorry.