Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling not one to one when zooming out #65757

Closed
richtabor opened this issue Sep 30, 2024 · 4 comments · Fixed by #65998 or #66012
Closed

Scaling not one to one when zooming out #65757

richtabor opened this issue Sep 30, 2024 · 4 comments · Fixed by #65998 or #66012
Assignees
Labels
[Feature] Zoom Out [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

The blocks within the canvas are not quite scaling properly when zooming out.

Taking a look at the recording below, you'll see the space between the site title and the navigation does not maintain and text is reflowing in the columns below.

CleanShot.2024-09-30.at.13.08.19.mp4
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Sep 30, 2024
@ndiego
Copy link
Member

ndiego commented Sep 30, 2024

I can confirm, and this does appear in 6.7 nightly, so I am adding it to the board.

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

Related:

#64117
#61465
#63390

@talldan
Copy link
Contributor

talldan commented Oct 1, 2024

From what I can tell it's because of the border style here:

// Firefox and Safari don't render margin-bottom here and margin-bottom is needed for Chrome
// layout, so we use border matching the background instead of margins.
border: calc(#{$frame-size} / #{$scale}) solid $gray-300;

Here's a video of it being toggled on and off:

Kapture.2024-10-01.at.17.45.28.mp4

I haven't managed to work out a good alternative that retains the space around the canvas in the way the border does.

@richtabor
Copy link
Member Author

// Firefox and Safari don't render margin-bottom here and margin-bottom is needed for Chrome

Is this valid? There’s no other way around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
7 participants