Fix zoom reflow by replacing border with padding #66012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
Backport to WP 6.7 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Oct 10, 2024
|
Size Change: -2 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e73856b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11272195985
|
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 10, 2024
Co-authored-by: richtabor <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: talldan <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 126acf2 |
|
This breaks the vertical toolbar as there is no longer a border on the left and right. |
|
On smaller screen, since we don't have the horizontal spacing, this happens with the toolbar: 
|
ajlende
reviewed
Oct 10, 2024
| @@ -19,9 +19,7 @@ | |||
|
|
|||
| background-color: $gray-300; | |||
|
|
|||
| // Firefox and Safari don't render margin-bottom here and margin-bottom is needed for Chrome | |||
| // layout, so we use border matching the background instead of margins. | |||
| border: calc(#{$frame-size} / #{$scale}) solid $gray-300; | |||
There was a problem hiding this comment.
When this border is removed, the border: 0 needs to be removed above L6.
ciampo
pushed a commit
that referenced
this pull request
Oct 14, 2024
Co-authored-by: richtabor <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: talldan <[email protected]>
ajlende
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: richtabor <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: talldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65757 by removing the applied border and applying padding instead.
Screenshots or screencast
Before
As seen in FireFox:
CleanShot.2024-10-10.at.12.22.13.mp4
After
CleanShot.2024-10-10.at.12.21.27.mp4