Zoom out: e2e for vertical toolbar appearance #65980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
MaggieCabrera
changed the title
MaggieCabrera
force-pushed
the
enable-zoom-out-e2e-tests
branch
from
39b3470
to
79aacfb
Compare
MaggieCabrera
force-pushed
the
e2e-vertical-toolbar
branch
from
86e8621
to
45c3cc7
Compare
|
Flaky tests detected in 69d9cbf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11290962837
|
|
Let's hold off on merging this one because we might change the vertical toolbar back to the normal one |
MaggieCabrera
force-pushed
the
e2e-vertical-toolbar
branch
from
69d9cbf
to
b88cd23
Compare
|
Should this get closed now that the vertical toolbar has been replaced with the default block toolbar? |
yeah, we can reopen if we ever bring it back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #65797
Right now based on top of #65943 until it gets merged
Why?
We didn't have any e2e tests for zoom out mode
How?
Checks if the vertical toolbar appears for a selected section on zoom out and checks that it's aligned correctly to the side of the section
Testing Instructions
Run
npm run test:e2e -- site-editor/zoom-out.spec.jsand the tests should pass