Backport Zoom out: fix scaling issues (#65998) to WP 6.7 #66047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
draganescu,
jeryj,
MaggieCabrera,
ajlende and
kevin940726
getdave
added
[Type] Bug
getdave
commented
Oct 11, 2024
Comment on lines
+1
to
+17
| .block-editor-iframe__container { | ||
| width: 100%; | ||
| height: 100%; | ||
| overflow-x: hidden; | ||
| } | ||
|
|
||
| .block-editor-iframe__scale-container { | ||
| height: 100%; | ||
| } | ||
|
|
||
| .block-editor-iframe__scale-container.is-zoomed-out { | ||
| $container-width: var(--wp-block-editor-iframe-zoom-out-container-width, 100vw); | ||
| $prev-container-width: var(--wp-block-editor-iframe-zoom-out-prev-container-width, 100vw); | ||
| width: $prev-container-width; | ||
| // This is to offset the movement of the iframe when we open sidebars | ||
| margin-left: calc(-1 * (#{$prev-container-width} - #{$container-width}) / 2); | ||
| } |
There was a problem hiding this comment.
@MaggieCabrera This file appears to have been deleted on wp/6.7 branch. But your PR includes it. Do you know what's going on there?
There was a problem hiding this comment.
I think the problem is we are missing this PR #65977
There was a problem hiding this comment.
Do we want to backport #65977 too?
There was a problem hiding this comment.
I don't know. Asked there. The dependencies here are getting really hard to follow what with work moving forward in Gutenberg Plugin.
There was a problem hiding this comment.
While #65977 isn't strictly necessary for 6.7, the risks from backporting are low and bugfixes like this are being made in the CSS that was moved. So I'd say we should backport it just to make this one easier.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
* changed from using borders to use pseudo elements * added comments * Include frame size in the scaling calculation Instead of adding the frame size as a border (which causes reflow issues), include the frame size in the scaling calculation so there's always a left/right gutter of the frame size. * Account for scaling in the frame height * Calculation in CSS * Revert "Calculation in CSS" This reverts commit 38de9fc. * Add comment about why the calculation for scaling needs to happen in the JS * Force px value for frameSize * Restore previous frameSize var setting * Add back line break * Use padding top/bottom instead of before/after for top/bottom frame * Remove more before/after css since we are using padding --------- Co-authored-by: Jerry Jones <[email protected]> Co-authored-by: Alex Lende <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: talldan <[email protected]> # Conflicts: # packages/block-editor/src/components/iframe/style.scss
kevin940726
force-pushed
the
pick/fix-zoom-out-scaling
branch
from
b8e2f85
to
ece23b4
Compare
|
Flaky tests detected in ece23b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11320740158
|
kevin940726
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65998