Iframed editor: Fix relative wp-content URLs #66751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tambourine-man, @Pat-Relentless, @nicolasleroy. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 5, 2024
| @@ -272,6 +272,7 @@ function Iframe( { | |||
| <html> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <base href="${ window.location.origin }"> | |||
There was a problem hiding this comment.
Does this work, regardless of how the site is configured (top level, sub folder, ...) and also for third-party block editors?
There was a problem hiding this comment.
This shouldn't matter for relative urls starting with /, they should always use the root.
But for relative urls that don't start with a slash it's trickier. We'd have always use the current post URL etc. This wouldn't work without an iframe either (in the admin), so not sure if it's worth fixing.
|
Btw I just tested this manually setting an image block's URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a
<base>element to the iframed editor to work with relative URLs.Fixes #54262
Rebase of #56533
Why?
Currently the editor in the iframe does not work with relative URLs.
Relative URLs work in the editor without iframe, where the media are loaded relative to the admin URL. The element restores the old behavior. In further iterations, we can make the editor even more flexible so that it can also work with other URLs.
Testing Instructions