Fix TS types for editor package #66754
Open
+3
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes TS types for editor package.
Why?
Currentl, the types for the package are broken because of the third-party types package -
@types/wordpress__editor
, which we can deprecate following this PR.How?
The problem with types was that the
store
object exported by the package was typed asobject
, which prevented the type generator from setting the types correctly. Thus this PR removes that type annotation to allow inference from importsTesting Instructions
useSelect
anduseDispatch
are broken and TS yells that the selector is not callable or the method doesn't exist. You can verify that things will work fine without the third-party typesTesting Instructions for Keyboard
Screenshots or screencast