Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCal: Encode spaces in team name #171

Merged
merged 4 commits into from
Dec 20, 2024
Merged

iCal: Encode spaces in team name #171

merged 4 commits into from
Dec 20, 2024

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Dec 20, 2024

In an attempt to resolve #169, see if the spaces in the url is causing the issue.

Fixes #169

@dd32
Copy link
Member Author

dd32 commented Dec 20, 2024

Confirmed this fixes it.

The issue is that Google is rejecting any URL with a space in it, because it needs to be URL Encoded.. which means double-url-encoded here..

Going to go a slightly different route, without the mucking with underscores.

@dd32 dd32 changed the title iCal: Replace spaces in team name with underscore. iCal: Encode spaces in team name Dec 20, 2024
@dd32 dd32 merged commit 67e9227 into master Dec 20, 2024
3 checks passed
@dd32 dd32 deleted the try/no-space-in-ical-file branch December 20, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Calendar link invalid
1 participant