Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core default value for viewport width #713

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

richtabor
Copy link
Member

@richtabor richtabor commented Dec 5, 2024

Fixes #683 by adjusting the previous 800 value for the default viewport width to 1200, which matches the default value in core. This way patterns render the same, regardless of source.

props @ryelle

@ryelle ryelle merged commit 7208ff5 into WordPress:trunk Dec 5, 2024
3 checks passed
@ryelle
Copy link
Contributor

ryelle commented Dec 5, 2024

@richtabor Thanks for the PR! I've deployed this, but it only affects the default value. Most patterns by wordpressdotorg have this value set already, and most of those use 800. There are some at 1200, 1000, and one at 600. If you want any of these updated let me know, I can do it from my sandbox.

+--------+--------------------------------------------------------------------------+---------------------+
| ID     | post_title                                                               | wpop_viewport_width |
+--------+--------------------------------------------------------------------------+---------------------+
| 489    | Two columns with image underneath                                        | 1200                |
| 526    | Offset images with descriptions                                          | 1200                |
| 192    | Media and text with image on the left                                    | 1200                |
| 491    | Full width image of space with big headline                              | 1200                |
| 557    | Half-width image of artistic squares with text                           | 1200                |
| 195    | Media and text with image on the right                                   | 1200                |
| 494    | Team social cards                                                        | 1200                |
| 572    | Image with headline and description                                      | 1200                |
| 514958 | Intro area with heading and image                                        | 1200                |
| 196    | Media and text in a full height container                                | 1200                |
| 499    | Three column staggered steps                                             | 1200                |
| 573    | Image on solid color with description                                    | 1200                |
| 197    | Two columns of text with offset heading                                  | 1200                |
| 502    | Event details                                                            | 1200                |
| 575    | Section divider with image and text                                      | 1200                |
| 199    | Three columns with images and text                                       | 1200                |
| 506    | Three quotes with images                                                 | 1200                |
| 576    | Title area with image and heading                                        | 1200                |
| 201    | Three columns with offset images                                         | 1200                |
| 678    | Three column pricing table                                               | 1200                |
| 507    | Header area with geometric pattern                                       | 1200                |
| 29     | Two columns of text and title                                            | 1200                |
| 577    | Introduction with image on the left                                      | 1200                |
| 477    | Two columns with full-width backgrounds                                  | 1200                |
| 516    | Header area with hatched pattern                                         | 1200                |
| 580    | Contact and social links                                                 | 1200                |
| 482    | Centered introduction text with button and offset images                 | 1200                |
| 517    | Full height banner with halftone pattern                                 | 1200                |
| 184    | Heading                                                                  | 1200                |
| 483    | Big image with headline and columns above                                | 1200                |
| 519    | Image with description on the bottom right                               | 1200                |
| 185    | Large header with left-aligned text                                      | 1200                |
| 488    | Three images and text                                                    | 1200                |
| 521    | Image with description below and to the right                            | 1200                |
| 186    | Large header with text and a button                                      | 1200                |
| 25     | Large header with a heading                                              | 1000                |
| 26     | Large header with a heading and a button                                 | 1000                |
| 28     | Three columns of text with buttons                                       | 1000                |
| 31     | Heading and paragraph                                                    | 1000                |
| 701    | Call to action with columns of text                                      | 800                 |
| 229143 | Centered footer with social links                                        | 800                 |
| 8      | Two columns of text with images                                          | 800                 |
| 1833   | Heading with image and text columns                                      | 800                 |
| 309935 | Centered image with two-tone background color                            | 800                 |
| 656    | Chapter opening                                                          | 800                 |
| 229097 | Simple header with dark background                                       | 800                 |
| 719    | Partner logos                                                            | 800                 |
| 229147 | Fullwidth footer with navigation, credit, and social                     | 800                 |
| 1856   | Image framed by a cover block                                            | 800                 |
| 350188 | Fullscreen fixed cover within another cover                              | 800                 |
| 661    | Horizontal Call to Action                                                | 800                 |
| 229101 | Text-only header with tagline                                            | 800                 |
| 727    | Two images with text and buttons                                         | 800                 |
| 229151 | Left-aligned footer                                                      | 800                 |
| 19     | Two images side by side                                                  | 800                 |
| 2075   | Two column 404                                                           | 800                 |
| 663    | Offset gallery with fixed background and quote                           | 800                 |
| 229105 | Simple header with tagline                                               | 800                 |
| 732    | Simple call to action                                                    | 800                 |
| 277127 | Fullwidth posts titles with dates                                        | 800                 |
| 2078   | Short text surrounded by round images                                    | 800                 |
| 576290 | Project Details                                                          | 800                 |
| 667    | Poster layout                                                            | 800                 |
| 229111 | Fullwidth site title and menu button                                     | 800                 |
| 763    | Image with angled overlay and text                                       | 800                 |
| 277265 | Fullwidth posts with uppercase titles                                    | 800                 |
| 2082   | Image and Calendar                                                       | 800                 |
| 669    | Image and quote on a background                                          | 800                 |
| 229116 | Fullwidth header with hero image                                         | 800                 |
| 830    | Call to Action with Testimonial                                          | 800                 |
| 303828 | Fullscreen cover image gallery                                           | 800                 |
| 2159   | Large background image with title and description                        | 800                 |
| 229123 | Centered footer with social links                                        | 800                 |
| 832    | Text column over fixed background                                        | 800                 |
| 308949 | Bold sale banner with geometric background                               | 800                 |
| 2225   | Two offset images with description                                       | 800                 |
| 684    | How It Works                                                             | 800                 |
| 229127 | Footer with search, site title, and credit line                          | 800                 |
| 838    | Introduction with Gallery                                                | 800                 |
| 309224 | Fullwidth, vertically aligned headline on right with description on left | 800                 |
| 229080 | Centered header with logo                                                | 800                 |
| 685    | Two images with shared colored strip                                     | 800                 |
| 229131 | Footer with site title and credit line                                   | 800                 |
| 845    | Cover with Title and Audio                                               | 800                 |
| 309230 | Fullwidth cover with repeating gradient text                             | 800                 |
| 597    | Social Gallery                                                           | 800                 |
| 229084 | Fullwidth header with large font size                                    | 800                 |
| 689    | Follow Card                                                              | 800                 |
| 229135 | Footer with navigation and credit line                                   | 800                 |
| 1748   | Two columns with images, text, and social icons                          | 800                 |
| 309236 | Fullwidth headline with links and gradient offset background             | 800                 |
| 603    | Recipe                                                                   | 800                 |
| 229088 | Simple header                                                            | 800                 |
| 694    | About Me Cards                                                           | 800                 |
| 229139 | Fullwidth footer with background color and three columns                 | 800                 |
| 1826   | Slanted background with text and a button                                | 800                 |
| 309925 | Fullwidth Dark Banner with Heading Top Left                              | 800                 |
| 622    | Restaurant Menu                                                          | 800                 |
| 229092 | Header inside full-width background image                                | 800                 |
| 15     | Three buttons                                                            | 600                 |
+--------+--------------------------------------------------------------------------+---------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patterns have a different viewport width than the default in core
2 participants