Only store info for relevant standalone plugins in the transient cache #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Enhancement
mukeshpanchal27
added
no milestone
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
approved these changes
Oct 1, 2024
felixarntz
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@mukeshpanchal27 Great catch!
PR looks good, though one recommendation to improve performance.
felixarntz
changed the title
|
FYI: We forgot to account for plugin dependencies here. Follow-up PR: #1613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1562
The current API query
https://api.wordpress.org/plugins/info/1.2/?action=query_plugins&request[author]=wordpressdotorg&request[tag]=performance&request[per_page]=100is returning some unrelated plugins likePlugin Check (PCP)andSQLite Database Integration. In the future, if anyone else usesPerformanceas a tag, it will also be added to ourtransient. However, we only need the standalone plugins defined inperflab_get_standalone_plugin_data().I’ve also moved the array definition for
$fieldsafter the cache check, as it's redundant in the cached version.