Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum PHP support to 7.4 #796

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 18, 2024

Fixes #791

@ernilambar ernilambar force-pushed the 791-minimum-php-version-bump branch 2 times, most recently from 73e7c77 to 8756d9d Compare November 18, 2024 15:47
@ernilambar ernilambar force-pushed the 791-minimum-php-version-bump branch from 8756d9d to 7f56cb3 Compare November 18, 2024 15:58
@ernilambar ernilambar added the Infrastructure Issues for the overall plugin infrastructure label Nov 18, 2024
@ernilambar ernilambar marked this pull request as ready for review November 18, 2024 16:00
Copy link

github-actions bot commented Nov 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

Can we do PHP 8.0+ instead? Would be more reasonable for a developer tool like this

@ernilambar
Copy link
Member Author

Can we do PHP 8.0+ instead? Would be more reasonable for a developer tool like this

Directory run in 7.4 I guess. It wont be feasible to run PCP in the directory if we bump to 8.0 now.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mukeshpanchal27
Copy link
Member

Per https://wordpress.org/about/stats/, After these PR get merged the total ~11.14% sites are not able to use PCP.

VersionUsage
7.33.30%
7.22.78%
7.10.70%
7.01.12%
5.62.28%
5.50.26%
5.40.31%
5.30.39%
5.20.17%

@ernilambar
Copy link
Member Author

Since this is developer targeted plugin, we may not have to stick with core's PHP philosophy, I guess.

Co-authored-by: Mukesh Panchal <[email protected]>
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 19, 2024
@ernilambar ernilambar merged commit e4e75f1 into trunk Nov 19, 2024
24 checks passed
@ernilambar ernilambar deleted the 791-minimum-php-version-bump branch November 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum PHP version bump
4 participants