Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for unsupported plugin name in plugin header field #825

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add check for unsupported plugin name in plugin header field #825

wants to merge 2 commits into from

Conversation

ernilambar
Copy link
Member

Fixes #805

@ernilambar ernilambar marked this pull request as ready for review December 10, 2024 07:07
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar
Copy link
Member Author

ernilambar commented Dec 10, 2024 •
edited
Loading

Tests are failing due to unrelated issue with this PR.

Edit: Tests are passing now.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 10, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Restrict plugin name with all unsupported characters
2 participants
@ernilambar @davidperezgar