Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique error code for each missing readme headers #839

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 19, 2024

For missing readme header, same error code missing_readme_header was used for all missing header items. Now error codes will be like:

  • missing_readme_header_tested
  • missing_readme_header_contributors

Unit test was missing for this error. Unit test has been added.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 19, 2024
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 19, 2024
@ernilambar ernilambar marked this pull request as ready for review December 19, 2024 09:12
Copy link

github-actions bot commented Dec 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar merged commit e7d1d80 into trunk Dec 20, 2024
29 checks passed
@davidperezgar davidperezgar deleted the improve-missing-readme-header branch December 20, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants