Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to comment lookup query #59

Merged
merged 11 commits into from
Feb 5, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Feb 5, 2024

What?

This adds pagination the the queries attempting to locate a previous comment from the bot to update.

Why?

The maximum number of items that can be returned by GitHub APIs is 100. When pull requests have a long history before receiving a comment from the bot, the bot will be unable to locate a previous comment and will continuously add new ones.

This fixes #54.

@desrosj desrosj self-assigned this Feb 5, 2024
@WordPress WordPress deleted a comment from github-actions bot Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: desrosj, jorbin, andrewserong.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <[email protected]>
Co-authored-by: aaronjorbin <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj marked this pull request as ready for review February 5, 2024 16:47
@desrosj desrosj merged commit d099497 into trunk Feb 5, 2024
6 checks passed
@desrosj desrosj deleted the fix/54-comment-search-pagination branch February 5, 2024 16:58
@andrewserong
Copy link
Contributor

Wonderful, thanks for fixing this up (and relatedly for the Co-authored-by note / props — lovely to see that you're using the bot within this repo, too! 😀)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The props bot sometimes adds repetitive comments rather than updating the existing comment
3 participants