Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for the camptix stripe addon #1275

Merged
merged 2 commits into from
Aug 13, 2024
Merged

test: add unit test for the camptix stripe addon #1275

merged 2 commits into from
Aug 13, 2024

Conversation

hideokamoto
Copy link
Contributor

Add a new PHPUnit test case for the class Camptix_Payment_Stripe_Addon on the Camptix plugin.

How to test the changes in this Pull Request:

  1. Run the phpunit command
  2. If it's not failed, it's okay.

pkevan
pkevan reviewed Aug 13, 2024
View reviewed changes
public_html/wp-content/plugins/camptix/tests/addons/test-payment-stripe.php Outdated
'USD', 10, 1000, // 10USD should be 1000
),
array(
'EUR', 10, 1000, // 10USD should be 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment should reference EUR

pkevan
pkevan approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, which I can fix up in a followup.

Unsure if this will automatically be added to phpunit (through github actions), but again, minor and can be rectified.

@pkevan
Copy link
Contributor

pkevan commented Aug 13, 2024

Unsure if this will automatically be added to phpunit (through github actions)

runs as expected with the additional tests against this PR.

@pkevan pkevan merged commit 81f49c5 into WordPress:production Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkevan pkevan pkevan approved these changes

Assignees
No one assigned
Labels
[Component] CampTix Including addons [Priority] Low [Type] Enhancement
Projects
Community Events Active Tasks
Status: ⛴️ Ready to ship
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hideokamoto @pkevan @renintw