Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub & SVN file syncing issue #1326

Merged
merged 8 commits into from
May 23, 2024
Merged

Conversation

renintw
Copy link
Contributor

@renintw renintw commented May 23, 2024

To avoid confusion, here's the approach being taken:

  1. Just like with SVN, revert the two commits that caused the issue.
  2. Then, reapply the "Needs Follow-up" status that didn't cause any problems.

See https://wordpress.slack.com/archives/C08M59V3P/p1716304671009819.

Props @pkevan

How to test the changes in this Pull Request:

  1. Log in as a network admin
  2. Open one and edit it, the staus should be visible
  3. Visit wp-admin/network/admin.php?page=reimbursement-requests-dashboard and tab "Needs follow-up" should be there
  4. On a WordCamp site, create a vendor payment and set due date to past date, set the status to "Needs follow-up"
  5. Visit /wp-admin/network/admin.php?page=wcp-dashboard and the payment should be listed on "Overdue" tab and separate "Needs follow-up" tab should be visible
  6. Reimbursement page should work as usual

@renintw renintw merged commit 7bcb5f4 into production May 23, 2024
3 checks passed
@renintw renintw deleted the fix/github-svn-syncing-issue branch May 23, 2024 15:22
@renintw renintw self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants