WC Post Types: Fix timezone offset when sessions happen after DST #1394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates how the session dates are converted when the site and client timezones are different. Rather than creating a fixed timezone offset on page load, this converts the times into the server timezone for the given date — this way, the offset is correctly applied if a future date is in a different timezone (DST starts or ends).
Fixes #1385.
The
date-fns
libraries added are also used in core/gutenberg, though they are bundled in the built script, not as externals. Since this in the editor, and it's not a huge library (not like moment), I think this is okay. Once an admin is editing sessions, it'll be cached from page to page.How to test the changes in this Pull Request:
Try with the site's timezone the same as your own & no during DST to ensure no regressions.