Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require address for invoice and prevent sending email without attachment #971

Closed
wants to merge 5 commits into from

Conversation

timiwahalahti
Copy link
Collaborator

It was reported that an invoice email was sent without the invoice attached if the address field was left empty by bypassing the required attribute with a space character.

In this PR, we prevent the email if there's no attachment and make the address field optional.

Fixes #255

Props dd32

Screenshots

image

How to test the changes in this Pull Request:

  1. Activate Camptix Invoices plugin and enable it on Camptix settings
  2. Go to tickets page, buy a ticket with invoice
  3. Address field shouldn't be required
  4. Invoice should be in email
  5. Go buy another ticket with invoice, but before that modify ctx_get_invoice to bail early with false value
  6. No invoice email received

@timiwahalahti
Copy link
Collaborator Author

Closing in favour of #965 which combines all the Camptix Invoices changes needed to make it network activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] CampTix Including addons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoices: Filling in the Address with a space causes an email without an attachment
1 participant