Do not require address for invoice and prevent sending email without attachment #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that an invoice email was sent without the invoice attached if the address field was left empty by bypassing the required attribute with a space character.
In this PR, we prevent the email if there's no attachment and make the address field optional.
Fixes #255
Props dd32
Screenshots
How to test the changes in this Pull Request:
ctx_get_invoice
to bail early with false value