Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress.tv: make the main heading on video pages an h1 #330

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

WordPress.tv: make the main heading on video pages an h1 #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed6337
Make the main heading on video pages an h1
jdevalk Jun 13, 2024
ea1f31b
More improvements
jdevalk Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wordpress.tv/public_html/wp-content/themes/wptv2/archive.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
global $wp_query, $post, $wptv;
?>
<div class="wptv-hero">
<h2 class="page-title"><?php
<h1 class="page-title"><?php
if ( is_category() ) :
printf( __( '&#8216;%s&#8217; Videos', 'wptv' ), single_cat_title( '', false ) );

Expand Down Expand Up @@ -45,7 +45,7 @@

endif;
?>
</h2>
</h1>
</div>
<div class="container">
<div class="primary-content">
Expand Down Expand Up @@ -94,4 +94,4 @@
<?php get_sidebar(); ?>
</div><!-- .container -->
<?php
get_footer();
get_footer();
2 changes: 1 addition & 1 deletion wordpress.tv/public_html/wp-content/themes/wptv2/category-wordcamptv.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<div class="wptv-hero group">
<div class="container">

<h2 class="page-title"><?php single_term_title(); ?></h2>
<h1 class="page-title"><?php single_term_title(); ?></h1>
<div class="desc"><?php echo category_description(); ?></div>

<?php if ( $featured->have_posts() ) : $featured->the_post(); ?>
Expand Down
2 changes: 1 addition & 1 deletion wordpress.tv/public_html/wp-content/themes/wptv2/category.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<div class="wptv-hero group">
<div class="container">

<h2 class="page-title"><?php single_term_title(); ?></h2>
<h1 class="page-title"><?php single_term_title(); ?></h1>
<div class="desc"><?php echo category_description(); ?></div>

<?php if ( have_posts() ) : the_post(); ?>
Expand Down
12 changes: 6 additions & 6 deletions wordpress.tv/public_html/wp-content/themes/wptv2/front-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@
<?php while ( $featured->have_posts() ) : $featured->the_post(); ?>
<div class="main-video">
<?php $wptv->the_video(); ?>
<h3>
<h2>
<a href="<?php the_permalink(); ?>" rel="bookmark" class="video-title"><?php the_title(); ?></a>
<?php $wptv->the_event( '<strong class="video-event">', '</strong>' ); ?>
</h3>
</h2>
</div><!-- .main-video -->
<?php endwhile; // $featured->have_posts ?>

<div class="secondary-videos">
<h3>
<h2>
<?php esc_html_e( 'WordCampTV', 'wptv' ); ?>
<a href="<?php echo home_url( '/category/wordcamptv/' ); ?>" class="view-more"><?php _e( 'More &rarr;', 'wptv' ); ?></a>
</h3>
</h2>
<ul>
<?php
$featured = new WP_Query( array( // WordCampTV Featured
Expand Down Expand Up @@ -79,7 +79,7 @@
<?php
if ( have_posts() ) :
?>
<h3><?php esc_html_e( 'Latest Videos', 'wptv' ); ?></h3>
<h2><?php esc_html_e( 'Latest Videos', 'wptv' ); ?></h2>
<ul class="video-list four-col">

<?php while ( have_posts() ) : the_post(); ?>
Expand Down Expand Up @@ -108,7 +108,7 @@

if ( $popular->have_posts() ) :
?>
<h3><?php esc_html_e( 'Popular Videos', 'wptv' ); ?></h3>
<h2><?php esc_html_e( 'Popular Videos', 'wptv' ); ?></h2>
<ul class="video-list four-col">

<?php while ( $popular->have_posts() ) : $popular->the_post(); ?>
Expand Down
4 changes: 3 additions & 1 deletion wordpress.tv/public_html/wp-content/themes/wptv2/header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
<div id="header">
<div class="sleeve">

<h1><a rel="home" href="<?php echo $wptv->home_url( '/' ); ?>"><img src="<?php echo get_template_directory_uri(); ?>/i/wptv-2x.png" alt="<?php echo esc_attr( get_bloginfo( 'name' ) ); ?>" height="40" width="210" /></a></h1>
<?php if ( is_front_page() ) { echo '<h1>'; } ?>
<a class="homelogo" rel="home" href="<?php echo $wptv->home_url( '/' ); ?>"><img src="<?php echo get_template_directory_uri(); ?>/i/wptv-2x.png" alt="<?php echo esc_attr( get_bloginfo( 'name' ) ); ?>" height="40" width="210" /></a></h1>
<?php if ( is_front_page() ) { echo '</h1>'; } ?>

<form id="searchform" name="searchform" method="get" action="<?php echo $wptv->home_url( '/' ); ?>">
<label for="searchbox" class="screen-reader-text"><?php esc_attr_e( 'Search WordPress.tv', 'wptv' ); ?></label>
Expand Down
12 changes: 6 additions & 6 deletions wordpress.tv/public_html/wp-content/themes/wptv2/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
?>

<div class="wptv-hero">
<h2 class="page-title"><?php esc_html_e( 'Archives', 'wptv' ); ?></h2>
<h1 class="page-title"><?php esc_html_e( 'Archives', 'wptv' ); ?></h1>
</div>
<div class="container">
<div class="primary-content">
Expand All @@ -32,18 +32,18 @@
<div class="video-description">
<div class="video-info">

<h5><?php esc_html_e( 'Published', 'wptv' ); ?></h5>
<h2 class="video-meta-heading"><?php esc_html_e( 'Published', 'wptv' ); ?></h2>
<p class="video-date"><?php the_date(); ?></p>

<?php if ( $post->post_excerpt ) : ?>
<div class="video-description"><?php the_excerpt(); ?></div>
<?php
endif;

$wptv->the_terms( 'event', '<h5>Event</h5><p class="video-event">', '<br /> ', '</p>' );
$wptv->the_terms( 'speakers', '<h5>Speakers</h5><p class="video-speakers">', '<br /> ', '</p>' );
$wptv->the_terms( 'post_tag', '<h5>Tags</h5><p class="video-tags">', '<br /> ', '</p>' );
$wptv->the_terms( 'language', '<h5>Language</h5><p class="video-lang">', '<br /> ', '</p>' );
$wptv->the_terms( 'event', '<h2 class="video-meta-heading">Event</h2><p class="video-event">', '<br /> ', '</p>' );
$wptv->the_terms( 'speakers', '<h2 class="video-meta-heading">Speakers</h2><p class="video-speakers">', '<br /> ', '</p>' );
$wptv->the_terms( 'post_tag', '<h2 class="video-meta-heading">Tags</h2><p class="video-tags">', '<br /> ', '</p>' );
$wptv->the_terms( 'language', '<h2 class="video-meta-heading">Language</h2><p class="video-lang">', '<br /> ', '</p>' );
?>
</div><!-- .video-info -->
</div>
Expand Down
6 changes: 3 additions & 3 deletions wordpress.tv/public_html/wp-content/themes/wptv2/page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
the_post();
?>
<div class="wptv-hero">
<h2 class="page-title">
<h1 class="page-title">
<?php the_title(); ?>
</h2>
</h1>
</div>

<div class="container">
Expand All @@ -32,4 +32,4 @@
<?php /*get_sidebar('page');*/ ?>
</div><!-- .container -->

<?php get_footer(); ?>
<?php get_footer(); ?>
2 changes: 1 addition & 1 deletion wordpress.tv/public_html/wp-content/themes/wptv2/single.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="container">

<?php get_template_part( 'breadcrumbs' ); ?>
<h2 class="video-title"><?php the_title(); ?></h2>
<h1 class="video-title"><?php the_title(); ?></h1>

<div class="the-video">
<?php $wptv->the_video(); ?>
Expand Down
6 changes: 3 additions & 3 deletions wordpress.tv/public_html/wp-content/themes/wptv2/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ div.success p {
display: table;
}

#header h1 {
#header .homelogo {
padding-top: 8px;
}

Expand Down Expand Up @@ -1929,7 +1929,7 @@ h4 {
margin: 20px 0 10px;
}

h5 {
h5, .video-meta-heading {
font-size: 12px;
font-weight: bold;
text-transform: uppercase;
Expand Down Expand Up @@ -2519,7 +2519,7 @@ h3#comments {
padding: 0 20px;
}

#header h1 {
#header .homelogo {
float: left;
}

Expand Down
6 changes: 3 additions & 3 deletions wordpress.tv/public_html/wp-content/themes/wptv2/taxonomy-event.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@
<div class="container">

<?php get_template_part( 'breadcrumbs' ); ?>
<h2 class="page-title"><?php single_term_title(); ?></h2>
<h1 class="page-title"><?php single_term_title(); ?></h1>

<?php if ( have_posts() ) : the_post(); ?>

<div class="main-video">
<?php $wptv->the_video(); ?>
<h3>
<h2>
<a href="<?php the_permalink(); ?>" rel="bookmark" class="video-title"><?php the_title(); ?></a>
<?php $wptv->the_event( '<strong class="video-event">', '</strong>' ); ?>
</h3>
</h2>
</div><!-- .main-video -->

<?php endif; ?>
Expand Down