Change the latest PHP to 8 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's time for this to be revisited. The main reason why this was risky when PHP 8.0 was released was due WordPress itself needing a bit more time to become compatible with PHP 8.x, and the changes in PHPUnit that required test classes to either be updated, or to run with the presence of a polyfill. Anyone that was using the Looking at GitHub, there's very few people actually using these containers in a |
aaronjorbin
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the version of PHP used in the
latesttags to8.2.I'm not sure we should merge this just yet though.
If we merge this, the latest PHPUnit image will become PHP 8 running PHPUnit 9.x, which is not supported by default by WordPress' test suite at the moment. Anyone relying on
latestin their setups would potentially see their tests break.