Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined WebAuthn UI #223

Merged
merged 18 commits into from
Aug 18, 2023
Merged

Refined WebAuthn UI #223

merged 18 commits into from
Aug 18, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Aug 7, 2023

Closes #194

Changes

Styles Security Keys screens to match design

NOTE: The animation has not been included at this stage. See #194 (comment)

List Register Disable
Screenshot 2023-08-10 at 1 32 46 PM Screenshot 2023-08-10 at 1 33 30 PM Screenshot 2023-08-10 at 3 24 07 PM

Adds Primary label on account settings screen, and updates disabled icons to better match design

Primary Disabled
Screenshot 2023-08-10 at 1 32 46 PM Screenshot 2023-08-10 at 3 45 56 PM

Consistent screen spacing

Part of the refinement includes making the space around the screen intro text consistent across all screens.

TOTP Email Password
Screenshot 2023-08-10 at 1 33 18 PM Screenshot 2023-08-10 at 3 27 56 PM Screenshot 2023-08-10 at 3 27 45 PM

Testing

Checkout this branch in your sandbox.

Either do a dev build of settings with NODE_ENV=development wp-scripts build --webpack-copy-php, or a prod build and remove the dev flag.

Check spacings in screens; there should be 40px margin around intro text and again around the action buttons.

Test registering and deleting security keys and check layout against designs.

Once Security Keys has been enabled, try disabling. You'll see an error message after the modal closes as the Two Factor Core code is not in place yet.

Check the screen list on the account status screen for badges and icons matching the state of 2FA providers

@adamwoodnz adamwoodnz linked an issue Aug 7, 2023 that may be closed by this pull request
@adamwoodnz adamwoodnz added this to the Iteration 1 milestone Aug 7, 2023
@adamwoodnz adamwoodnz self-assigned this Aug 7, 2023
@adamwoodnz adamwoodnz force-pushed the add/194-refine-webauthn-visual-design branch from e7e3203 to c60c89e Compare August 10, 2023 01:16
@adamwoodnz adamwoodnz marked this pull request as ready for review August 10, 2023 03:34
@adamwoodnz adamwoodnz requested review from iandunn and renintw August 10, 2023 03:34
@adamwoodnz adamwoodnz added the ui Related to user interface label Aug 10, 2023
Copy link
Contributor

@renintw renintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have each scenario tested, the design and the code both look good to me! 👍
Only that in the design the delete key button in the security key section doesn't have an underline, but it has one here.
I remember not having an underline might go against a11y practices, though.

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to user interface
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refine WebAuthn visual design
4 participants